Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps egui and eframe #13

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Conversation

tomtuamnuq
Copy link
Contributor

Closes #12

Similar to the two pull requests regarding the previous versions of egui 0.24 and 0.23.

epaint version 0.25 introduced a breaking change in TextShape::new, see the Pull Request in egui. Using the Color::PLACEHOLDER should be sufficient as argument here, since a colored galley is used (see line 359 in src/backend.rs) @Gip-Gip what do you think?

Code compiles and works within my wasm project (3D chart - thanks for this!!!) with rust version 1.75. I have not checked the native examples egui-plotter/examples.

@cptyannick
Copy link

I am currently working through the native Chart-example, and it compiles and works fine! Thanks, tomtuamnuq!

@Gip-Gip
Copy link
Owner

Gip-Gip commented Feb 24, 2024

apologies, been busy and will merge this soon. Thanks!

@Gip-Gip Gip-Gip merged commit 00888c0 into Gip-Gip:main Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use with egui/eframe 0.25
3 participants